[NSFS] Add support for restore-object #7507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
force-pushed
the
utkarsh/add/restore-api-iter2
branch
3 times, most recently
from
cdb3bc8
to
057611a
Compare
romayalon
reviewed
Sep 26, 2023
romayalon
reviewed
Sep 26, 2023
|
@tangledbytes what about adding a few unit tests? :) |
tangledbytes
force-pushed
the
utkarsh/add/restore-api-iter2
branch
3 times, most recently
from
77a8d88
to
4e341f0
Compare
romayalon
reviewed
Sep 26, 2023
tangledbytes
force-pushed
the
utkarsh/add/restore-api-iter2
branch
2 times, most recently
from
8a7f4b9
to
428533e
Compare
tangledbytes
force-pushed
the
utkarsh/add/restore-api-iter2
branch
from
428533e
to
d3fb389
Compare
guymguym
reviewed
Sep 28, 2023
guymguym
approved these changes
Sep 28, 2023
| const restore = [`ongoing-request="${object_md.restore_status.ongoing}"`]; | ||
| if (!object_md.restore_status.ongoing && object_md.restore_status.expiry_time) { | ||
| // Expiry time is in UTC format | ||
| const expiry_date = new Date(object_md.restore_status.expiry_time).toUTCString(); |
There was a problem hiding this comment.
but what is the date format of the xattr user.noobaa.restore.expiry ?
is it a number? worth noting it here in the comment at least.
in nb.d.ts I see this is a Date... So unclear.
There was a problem hiding this comment.
Mentioned the format in the xattr comment (All the data types are mentioned in the comments).
Comment on lines
+67
to
+78
| /** | ||
| * XATTR_RESTORE_EXPIRY is set to a ISO DATE by the underlying restore process or by | ||
| * NooBaa (in case restore is issued again while the object is on disk). | ||
| * This is read by the underlying "disk evict" process to determine if the object | ||
| * should be evicted from the disk or not. | ||
| * | ||
| * NooBaa will use this date to determine if the object is on disk or not, if the | ||
| * expiry date is in the future, the object is on disk, if the expiry date is in | ||
| * the past, the object is not on disk. This may or may not represent the actual | ||
| * state of the object on disk, but is probably good enough for NooBaa's purposes | ||
| * assuming that restore request for already restored objects fails gracefully. | ||
| */ |
There was a problem hiding this comment.
noice comment! I wish we had such comments on all our xattrs...
tangledbytes
force-pushed
the
utkarsh/add/restore-api-iter2
branch
2 times, most recently
from
b66ad0b
to
5ac2631
Compare
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add changes to nb.d.ts Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix errors when no storage class is provided - treat as STANDARD Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix storage class assignment Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> address minor comments on the PR Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add unit tests and minor fixes Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix unit tests Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix lint error Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix _is_storage_class_supported Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix unit test Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> revamp the implementation to adhere more closely to S3 behaviours Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add assertions to ensure xattrs aren't leaked into objectmds Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> cleanup restore_status logic and fix expiry extension Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix broken get_object Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
tangledbytes
force-pushed
the
utkarsh/add/restore-api-iter2
branch
from
5ac2631
to
64ce3cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR adds
restore-objectAPI in NSFS.storage-classinhead/get-object.