Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log based replication | Add copy object flow for versioned objects #7508

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

liranmauda
Copy link
Contributor

Explain the changes

  • Add copy object flow for versioned objects

Note:

in the case of a few objects with the same prefix, all these objects up to a maximum of REPLICATION_MAX_KEYS (or 1000) will be processed and replicated.
e.g.
if we have an object name test.text and it have 3 versions
and if we also have test1.text and test2.text which also have few versions,
and the log hints that test.text was written, all of those objects and their versions (up to 1000 as default) will be processed and replicated.

Note 2:

in the case of sync-version, there will be no difference between copy and delete operations process.
This is because we still need to be aware of the version's history and may even do a copy before we do a delete (which should only be if the delete marker is the latest.)

Testing Instructions:

  1. Disable scanner replication in the config.js: config.REPLICATION_ENABLED = false;
  2. Create a replication with log-based and sync_version
  3. See that all the objects are getting replicated

- Add copy object flow for versioned objects

Signed-off-by: liranmauda <liran.mauda@gmail.com>
@liranmauda liranmauda merged commit ef41620 into noobaa:master Sep 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants