Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase timeout for bucket policy unit tests #7511

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

nadavMiz
Copy link
Contributor

@nadavMiz nadavMiz commented Sep 27, 2023

Explain the changes

  1. increase the timeout for unit tests that are failing on exceeded timeout.
  2. timeout was increased to 15000, this number was chosen based on timeout that was set for similar tests in the same file

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. run unit tests for bucket policy. tests should pass
  • Doc added/updated
  • Tests added

@nadavMiz nadavMiz requested review from shirady, a team and naveenpaul1 and removed request for a team September 27, 2023 08:19
Signed-off-by: nadav mizrahi <nadav.mizrahi16@gmail.com>
@nadavMiz
Copy link
Contributor Author

some of the bucket policy sometimes fails in the CI for timeout exceeded. this is an example of the issue observed in the logs:

2023-09-26T15:46:31.1166445Z   3421 passing (23m)
2023-09-26T15:46:31.1177169Z   18 pending
2023-09-26T15:46:31.1188507Z   1 failing
2023-09-26T15:46:31.1199752Z
2023-09-26T15:46:31.1224495Z   1) s3_bucket_policy
2023-09-26T15:46:31.1224830Z        should be able to set bucket policy when none set:
2023-09-26T15:46:31.1225857Z      Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/root/node_modules/noobaa-core/src/test/unit_tests/index.js)
2023-09-26T15:46:31.1226417Z       at listOnTimeout (node:internal/timers:569:17)
2023-09-26T15:46:31.1226780Z       at process.processTimers (node:internal/timers:512:7)
```bash

Copy link
Contributor

@shirady shirady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadavMiz nadavMiz merged commit ec1a91a into noobaa:master Sep 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants