Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | CLI | fix nsfs cli uid/gid=0 issue #7515

Merged
merged 1 commit into from
Sep 28, 2023
Merged

NSFS | NC | CLI | fix nsfs cli uid/gid=0 issue #7515

merged 1 commit into from
Sep 28, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. when uid/gid = 0 we fail with 'Error: Account config should not be empty' because of the following condition evaluates to true - !data.nsfs_account_config.uid || !data.nsfs_account_config.gid so I changed the check

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon
fix nsfs cli small issue
6ad573d 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 40956d2 into noobaa:master Sep 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @naveenpaul1