Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | Fix nsfs simple fs tool #7517

Merged
merged 1 commit into from
Oct 1, 2023
Merged

NSFS | Fix nsfs simple fs tool #7517

merged 1 commit into from
Oct 1, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Oct 1, 2023 •
edited

Explain the changes

  1. A few functions like bucket policy etc were commented out due to the recent NC changes, also the bucket policy structure was updated to Upper case on master so I fixed it.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. Open 2 termial tabs -
  2. Tab 1 - run sudo node src/cmd/nsfs /path/to/fs_root/ --simple
  3. Tab 2 - run s3 commands to localhost:6443/6001
  • Doc added/updated
  • Tests added

@romayalon
fix simple fs bucket policy
d203140 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@alphaprinz alphaprinz self-requested a review October 1, 2023 09:02
alphaprinz
alphaprinz approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@alphaprinz alphaprinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon romayalon merged commit e09d20e into noobaa:master Oct 1, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alphaprinz alphaprinz alphaprinz approved these changes

@liranmauda liranmauda Awaiting requested review from liranmauda

@nadavMiz nadavMiz Awaiting requested review from nadavMiz

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @alphaprinz