Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | nsfs service additions #7518

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. Added needed env vars to nsfs service
  2. Added a check when creating fs_napi for GPFS lib file existence before reading the lib file - and added this check boolean in use_gpfs_lib().

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/MCGI-201

Testing Instructions:

  1. Run NC nsfs with the GPFS path as env variable while lib file exists
  2. Run NC nsfs with the GPFS path as env variable while lib file does not exist
  3. Run NC nsfs without the GPFS path as env variable
  • Doc added/updated
  • Tests added

@romayalon romayalon force-pushed the romy-load-gpfs-lib branch 2 times, most recently from b45f372 to 9dec77c Compare October 3, 2023 06:53
@romayalon
Copy link
Contributor Author

@tangledbytes I added a default nsfs_env.env file as an example that should be linked to /etc/noobaa.conf.d/.env
and added it as an environmentFile to be used in nsfs.service, please re-check it

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 94886a0 into noobaa:master Oct 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants