Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.14] omit postgres password from log messages in postgres_client #7523

Merged
merged 1 commit into from
Oct 10, 2023
Merged

[5.14] omit postgres password from log messages in postgres_client #7523

merged 1 commit into from
Oct 10, 2023

Conversation

dannyzaken
Copy link
Contributor

Explain the changes

  1. omit password from the printed object this.new_pool_params which contains the DB password

Issues: Fixed #xxx / Gap #xxx

  1. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2240778

Testing Instructions:

  1. start noobaa-core
  2. grep log for messages with the string postgres_client:: _connect
  3. after the fix, the json in the message should not contain the password field.
  • Doc added/updated
  • Tests added

@dannyzaken dannyzaken changed the title omit postgres password from log messages in postgres_client [5.14] omit postgres password from log messages in postgres_client Oct 4, 2023
@dannyzaken
omit postgres password from log messages in postgres_client
4c5f7ec 
Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
@dannyzaken dannyzaken merged commit c9e148c into noobaa:5.14 Oct 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nimrod-becker nimrod-becker nimrod-becker approved these changes

@jackyalbo jackyalbo Awaiting requested review from jackyalbo

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dannyzaken @nimrod-becker