Added a check for bidirectional replication for matching prefix #7524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
reviewed
Oct 5, 2023
| const replication_rules = req.rpc_params.replication_policy.rules; | ||
| // num of rules in configuration must be in defined limits | ||
| if (replication_rules.length > config.BUCKET_REPLICATION_MAX_RULES || | ||
| replication_rules.length < 1) throw new RpcError('INVALID_REPLICATION_POLICY', 'Number of rules is invalid'); | ||
|
|
||
| const rule_ids = []; | ||
| const pref_by_dst_bucket = {}; | ||
| const src_bucket = req.system.buckets_by_name && req.system.buckets_by_name[req.name]; |
There was a problem hiding this comment.
why not get it from the rule in this request?
At this point we do not care about the bucket, only about it's name
There was a problem hiding this comment.
Here, as in rules bucket id is stored in the DB so we need the bucket id instead of name to compare.
liranmauda
reviewed
Oct 5, 2023
liranmauda
reviewed
Oct 5, 2023
liranmauda
reviewed
Oct 5, 2023
liranmauda
requested changes
Oct 5, 2023
achouhan09
force-pushed
the
bidir_val
branch
2 times, most recently
from
a07a84d
to
9d63c0e
Compare
achouhan09
force-pushed
the
bidir_val
branch
11 times, most recently
from
7491ae6
to
c0bf229
Compare
liranmauda
reviewed
Oct 18, 2023
…g prefixes 2. Added tests for bidirectional replication validation Signed-off-by: Aayush Chouhan <aayush.chouhan97@gmail.com>
liranmauda
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes