Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | NSFS | HTTP and certificate configurations #7533

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

naveenpaul1
Copy link
Contributor

Explain the changes

  1. create allow/deny http configuration - take it from noobaa.conf.d/system.json
    certificate file location, see - ssl_utils.js - take it from noobaa.conf.d/system.json
    system.json
    { "current_version": "5.15.0", "upgrade_history": { "successful_upgrades": [] }, "allow_http": false, "nsfs_ssl_cert_dir": "/etc/nc_nsfs_secret" }

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/MCGI-203

Testing Instructions:

  • Doc added/updated
  • Tests added

Copy link
Contributor

@romayalon romayalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some minor questions

src/endpoint/endpoint.js Outdated Show resolved Hide resolved
src/util/ssl_utils.js Outdated Show resolved Hide resolved
src/util/ssl_utils.js Outdated Show resolved Hide resolved
src/cmd/nsfs.js Outdated Show resolved Hide resolved
docs/non_containerized_NSFS.md Show resolved Hide resolved
Copy link
Contributor

@romayalon romayalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: naveenpaul1 <napaul@redhat.com>
@naveenpaul1 naveenpaul1 merged commit 058498b into noobaa:master Oct 20, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants