Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logs In http_utils.js #7535

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Oct 17, 2023

Explain the changes

  1. Add logs in levels 2 and 3 to help support and developers understand the parameters that we have in the functions _get_http_agent and should_proxy. It was not set in debug level 0 or 1 because every creation of S3 Client with an agent would call those functions.

Issues: Fixed #xxx / Gap #xxx

  1. none, I had a BZ 2238334 where I had to assume the values and do a dry-run to understand what happens. It could be easier for support and developers to find those values in the logs in such cases.

Testing Instructions:

  1. Deploy noobaa on MInikube or Rancher Desktop (see guide).
    Note: nb is an alias that runs the local operator from build/_output/bin (alias created by devenv).
  2. Set debug level of 3 by running: nb system set-debug-level 3
  3. Create a new backingstore: nb backingstore create aws-s3 <backing-store-name> (optional: add the --region flag).
  4. Check the logs of noobaa-core: k logs noobaa-core-0 -f look for should_proxy: and _get_http_agent: printings.
  • Doc added/updated
  • Tests added

@shirady shirady self-assigned this Oct 17, 2023
@shirady shirady requested review from dannyzaken, a team and alphaprinz and removed request for a team October 17, 2023 12:09
add logs in level 2 and 3 to help support and developers understand the parameters that we have in the functions _get_http_agent and should_proxy.

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady merged commit c96a54b into noobaa:master Oct 23, 2023
8 checks passed
@shirady shirady deleted the add-logs-proxy-settings branch November 12, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants