Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
_get_http_agent
andshould_proxy
. It was not set in debug level 0 or 1 because every creation of S3 Client with an agent would call those functions.Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
Note:
nb
is an alias that runs the local operator frombuild/_output/bin
(alias created bydevenv
).nb system set-debug-level 3
nb backingstore create aws-s3 <backing-store-name>
(optional: add the--region
flag).k logs noobaa-core-0 -f
look forshould_proxy:
and_get_http_agent:
printings.