Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | fix bucket policy issue #7536

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Oct 18, 2023

Explain the changes

  1. bucketspace_fs.read_bucket_sdk_info() added iteration on existing bucket policies in order to convert plain principals (email/"*") string to sensitive strings.
  2. bucketspace_fs.put_bucket_policy() - added validate_s3_policy() call.
  3. moved validate_s3_policy() func from bucket_server to bucket_policy_utils so it can be re-used by bucketspace_fs.
    since we don't have a system store in NC env, we currently won't check existence of accounts mentioned in bucket policies (see Gaps).
  4. Added unit tests

Issues: Fixed #xxx / Gap #xxx

  1. Currently we won't check for existence of the accounts provided in the bucket policy as it requires a new account_by_email cache or a different solution.
  2. Fixed principal.unwrap is not a function #7527

Testing Instructions:

  • Doc added/updated
  • Tests added

Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a small comment, LGTM

src/endpoint/s3/s3_bucket_policy_utils.js Outdated Show resolved Hide resolved
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit cc238e1 into noobaa:master Oct 23, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

principal.unwrap is not a function
2 participants