Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | removing system store requirement from nsfs.js #7545

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Oct 25, 2023

Explain the changes

  1. System store requirement initiating the constructor of the system Store which defines the db collections. while defining db collection the vacumeAnalyzer is set to run once a day so the nsfs process panics when it happens.
    currently, it's not being used so I suggest removing this requirement.
    at _do_query (/Users/romy/github/noobaa-core/src/util/postgres_client.js:250:37)
    at PostgresTable.single_query (/Users/romy/github/noobaa-core/src/util/postgres_client.js:679:16)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:538:9)
    at process.processTimers (node:internal/timers:512:7)
    at async Timeout.vacuumAndAnalyze [as _onTimeout] (/Users/romy/github/noobaa-core/src/util/postgres_client.js:700:13)
/Users/romy/github/noobaa-core/src/util/postgres_client.js:250
        const res = await pg_client.query(q);
                                    ^

TypeError: Cannot read properties of undefined (reading 'query')
    at _do_query (/Users/romy/github/noobaa-core/src/util/postgres_client.js:250:37)
    at PostgresTable.single_query (/Users/romy/github/noobaa-core/src/util/postgres_client.js:679:16)
    at runNextTicks (node:internal/process/task_queues:60:5)
    at listOnTimeout (node:internal/timers:538:9)
    at process.processTimers (node:internal/timers:512:7)
    at async Timeout.vacuumAndAnalyze [as _onTimeout] (/Users/romy/github/noobaa-core/src/util/postgres_client.js:700:13)

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 714caed into noobaa:master Oct 26, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants