Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | github action for manual & nightly rpm build and upload it as artifact / s3 #7561

Merged
merged 1 commit into from
Nov 6, 2023
Merged

NSFS | NC | github action for manual & nightly rpm build and upload it as artifact / s3 #7561

merged 1 commit into from
Nov 6, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Nov 1, 2023 •
edited

Explain the changes

  1. Added manual RPM build
  2. Added nightly RPM build.
  3. uploaded the created RPM as artifact, nightly build will upload it to s3 as well.
  4. makefile - replaced -it with -t in order to get TTY env on the github action.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon changed the title NSFS | NC | github action for manual build rpm and upload it as artifact NSFS | NC | github action for manual rpm build and upload it as artifact Nov 1, 2023
liranmauda
liranmauda reviewed Nov 2, 2023
View reviewed changes
.github/workflows/manual-build-rpm.yaml Outdated Show resolved Hide resolved
.github/workflows/manual-build-rpm.yaml Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 5, 2023
@romayalon
parent c60a3f2
2c4a235 
author Romy <35330373+romayalon@users.noreply.github.com> 1698846943 +0200
committer Romy <35330373+romayalon@users.noreply.github.com> 1698857625 +0200

manual build rpm

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 04db268 into noobaa:master Nov 6, 2023
8 checks passed
@romayalon romayalon changed the title NSFS | NC | github action for manual rpm build and upload it as artifact NSFS | NC | github action for manual & nightly rpm build and upload it as artifact / s3 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

@guymguym guymguym Awaiting requested review from guymguym

@tangledbytes tangledbytes Awaiting requested review from tangledbytes

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1

@liranmauda liranmauda Awaiting requested review from liranmauda

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@romayalon @dannyzaken @liranmauda