Standalone | CLI | fix account list issues #7568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
force-pushed
the
liran-fix-help-text
branch
2 times, most recently
from
b676509
to
7661df4
Compare
romayalon
reviewed
Nov 8, 2023
romayalon
reviewed
Nov 8, 2023
liranmauda
force-pushed
the
liran-fix-help-text
branch
8 times, most recently
from
dc4d4e1
to
19c84ed
Compare
romayalon
reviewed
Nov 12, 2023
liranmauda
force-pushed
the
liran-fix-help-text
branch
from
19c84ed
to
c6c7651
Compare
romayalon
reviewed
Nov 12, 2023
liranmauda
force-pushed
the
liran-fix-help-text
branch
2 times, most recently
from
9196011
to
1e0d6f2
Compare
- Status now listed with all the details present in the manifest, except for the access_keys and nsfs_account_config - added --wide flag to list to show all the details present in the manifest per acount (same as status) Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
force-pushed
the
liran-fix-help-text
branch
from
1e0d6f2
to
af27d3d
Compare
|
@liranmauda please add unit tests and the relevant changes to the docs |
romayalon
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
As discussed on slack, @liranmauda will add the relevant docs and unit tests on a follow up PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx