Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Object Tagging #7572

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Nov 8, 2023

Explain the changes

  1. Tagging should be supported by nsfs
  2. Can be stored as simple key-value xattrs with some prefix e.g user.noobaa.tag.KEY=VALUE

Issues: Fixed #xxx / Gap #xxx

  1. NSFS Object tagging support needed #7454

Testing Instructions:

  1. try to put, get and delete object tag with bellow comands
    aws s3api put-object-tagging --tagging '{"TagSet": [{ "Key": "designation", "Value": "confidential" }, { "Key": "department", "Value": "finance" }, { "Key": "team", "Value": "payroll" } ]}' --bucket {bucke-name} --key {object-key} --endpoint https://localhost:6443 --no-verify-ssl

aws s3api get-object-tagging --bucket {bucke-name} --key {object-key}--endpoint https://localhost:6443 --no-verify-ssl

aws s3api delete-object-tagging --bucket {bucke-name} --key {object-key} --endpoint https://localhost:6443 --no-verify-ssl

  • Doc added/updated
  • Tests added

src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
src/sdk/namespace_fs.js Outdated Show resolved Hide resolved
Signed-off-by: naveenpaul1 <napaul@redhat.com>
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naveenpaul1 naveenpaul1 merged commit 2680b12 into noobaa:master Nov 15, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants