-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSFS | NC | Object Tagging #7572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveenpaul1
requested review from
liranmauda,
romayalon,
tangledbytes and
dannyzaken
November 8, 2023 11:58
naveenpaul1
force-pushed
the
nsfs_object_tagging
branch
4 times, most recently
from
November 13, 2023 04:58
e005aaf
to
9cf3aa1
Compare
naveenpaul1
force-pushed
the
nsfs_object_tagging
branch
from
November 13, 2023 11:18
14d3fa8
to
f57f842
Compare
naveenpaul1
force-pushed
the
nsfs_object_tagging
branch
2 times, most recently
from
November 13, 2023 11:58
ae586c0
to
de31a47
Compare
liranmauda
reviewed
Nov 14, 2023
naveenpaul1
force-pushed
the
nsfs_object_tagging
branch
from
November 14, 2023 14:20
a683c26
to
bcd560c
Compare
liranmauda
reviewed
Nov 14, 2023
naveenpaul1
force-pushed
the
nsfs_object_tagging
branch
from
November 15, 2023 07:43
bcd560c
to
5cfcba6
Compare
liranmauda
reviewed
Nov 15, 2023
Signed-off-by: naveenpaul1 <napaul@redhat.com>
naveenpaul1
force-pushed
the
nsfs_object_tagging
branch
from
November 15, 2023 09:01
5cfcba6
to
4260766
Compare
liranmauda
approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
romayalon
reviewed
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
user.noobaa.tag.KEY=VALUE
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
aws s3api put-object-tagging --tagging '{"TagSet": [{ "Key": "designation", "Value": "confidential" }, { "Key": "department", "Value": "finance" }, { "Key": "team", "Value": "payroll" } ]}' --bucket {bucke-name} --key {object-key} --endpoint https://localhost:6443 --no-verify-ssl
aws s3api get-object-tagging --bucket {bucke-name} --key {object-key}--endpoint https://localhost:6443 --no-verify-ssl
aws s3api delete-object-tagging --bucket {bucke-name} --key {object-key} --endpoint https://localhost:6443 --no-verify-ssl