Support role config deletion #7573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyzaken
reviewed
Nov 9, 2023
src/api/common_api.js
Outdated
| @@ -1342,6 +1342,9 @@ module.exports = { | |||
| }, | |||
| assume_role_policy: { | |||
| $ref: '#/definitions/assume_role_policy' | |||
| }, | |||
| delete: { | |||
There was a problem hiding this comment.
Although it was my suggestion, I think we shouldn't add the delete here 🙂
The role_config is also used in the account_schema, and it might confuse.
Maybe it is better to add a delete_role_config flag in the update_account params, as you initially suggested
Signed-off-by: Ben <belimele@redhat.com>
Neon-White
force-pushed
the
support-role-cfg-deletion
branch
from
af2c48c
to
c4200a3
Compare
dannyzaken
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR adds support for a role config deletion flag that can be set to
trueif a user wishes to delete an account's role configIssues: Fixed #xxx / Gap #xxx
This PR is necessary for operator PR 1238