Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace revisions with current date #7575

Merged

Conversation

tangledbytes
Copy link
Member

Explain the changes

This PR replaces the fixed revision from 1 to current date.

Testing Instructions:

  1. Run make rpm
  2. Check the generated RPM name, it should be of the format noobaa-core-$(version)-$(date).
  • Doc added/updated
  • Tests added

@tangledbytes
Copy link
Member Author

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>

update RPM versioning in GH workflows

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Just one question the RPM is marked as RHEL8, any reason?

@tangledbytes
Copy link
Member Author

LGTM, Just one question the RPM is marked as RHEL8, any reason?

No specific reason actually I guess 🤔

@tangledbytes tangledbytes merged commit c0d4e2e into noobaa:master Nov 9, 2023
9 checks passed
@liranmauda liranmauda mentioned this pull request Nov 16, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants