Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI | Update Ceph S3 Tests (Commit Hash Number and Pending Lists) #7589

Merged
merged 1 commit into from
Nov 13, 2023
Merged

CI | Update Ceph S3 Tests (Commit Hash Number and Pending Lists) #7589

merged 1 commit into from
Nov 13, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Nov 13, 2023 •
edited

Explain the changes

  1. Update Ceph S3 test commit hash number (taken from here).
  2. Added new and failed tests to the pending list of Ceph tests.

Issues: Fixed #xxx / Gap #xxx

  1. GAP - currently the Ceph test CI (not NSFS) passes although it contains failed tests.
  2. Without this change all out CI tests are failing with the message:

ceph tests were not updated for 180 days, Exiting.

Testing Instructions:

  1. none (tested through the CI).
  • Doc added/updated
  • Tests added

@shirady
Copy link
Contributor Author

shirady commented Nov 13, 2023

Ceph S3 Tests output before changing the pending list:

Nov-13 9:26:57.417 [test_ceph_s3/184] [ERROR] CONSOLE:: CEPH TEST FAILED TESTS SUMMARY: 5 failed tests
s3tests_boto3/functional/test_s3.py::test_post_object_wrong_bucket
s3tests_boto3/functional/test_s3.py::test_object_raw_get_x_amz_expires_not_expired
s3tests_boto3/functional/test_s3.py::test_object_raw_get_x_amz_expires_not_expired_tenant
s3tests_boto3/functional/test_s3.py::test_cors_presigned_get_object
s3tests_boto3/functional/test_s3.py::test_cors_presigned_get_object_tenant
Nov-13 9:26:57.418 [test_ceph_s3/184] [ERROR] CONSOLE:: Ceph Test Failed: Error: Ceph Tests Returned with Failures

NSFS Ceph S3 Tests output before changing the pending list:

Nov-13 9:02:00.988 [test_ceph_s3/65] [ERROR] CONSOLE:: CEPH TEST FAILED TESTS SUMMARY: 5 failed tests
s3tests_boto3/functional/test_s3.py::test_object_raw_get_x_amz_expires_not_expired
s3tests_boto3/functional/test_s3.py::test_object_raw_get_x_amz_expires_not_expired_tenant
s3tests_boto3/functional/test_s3.py::test_cors_presigned_get_object
s3tests_boto3/functional/test_s3.py::test_cors_presigned_get_object_tenant
s3tests_boto3/functional/test_s3.py::test_encryption_sse_c_unaligned_multipart_upload

naveenpaul1
naveenpaul1 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shirady shirady self-assigned this Nov 13, 2023
@shirady
update Ceph S3 tests
6fcc570 
1. update Ceph S3 test commit hash number
2. added new and failed tests to the pending list of Ceph tests

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
@shirady shirady changed the title CI | Update Ceph S3 Test Commit Hash Number CI | Update Ceph S3 Tests (Commit Hash Number and Pending Lists) Nov 13, 2023
@shirady shirady merged commit f46710f into noobaa:master Nov 13, 2023
9 checks passed
@shirady
Copy link
Contributor Author

shirady commented Nov 13, 2023

@tangledbytes @v-harihar FYI.

@shirady shirady deleted the update-ceph-commit branch November 13, 2023 11:26
@shirady shirady mentioned this pull request Jan 2, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

Assignees

@shirady shirady

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shirady @naveenpaul1