NSFS | NC | Configuration | accounts/ and access_keys/ directories changes #7591

romayalon · 2023-11-13T11:35:29Z

Explain the changes

replace the current accounts/access_key.json structure with accounts/name.json and the corresponding access_keys/access_key.symlink -

/etc/noobaa.conf.d/accounts/alice.json  --> { "name": "alice", "access_keys": [{ "access_key": "ABCD", "secret_key": "***" }], ... }
/etc/noobaa.conf.d/access_keys/ABCD.symlink --> /etc/noobaa.conf.d/accounts/alice.json

fix account update name/access key
fix bucket update name
unit tests addition

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

sudo node ./node_modules/mocha/bin/mocha /Users/username/github/noobaa-core/src/test/unit_tests/test_bucketspace_fs.js
sudo node ./node_modules/mocha/bin/mocha /Users/username/github/noobaa-core/src/test/unit_tests/test_nc_nsfs_cli.js

Doc added/updated
Tests added

src/cmd/manage_nsfs.js

src/test/unit_tests/test_bucketspace_fs.js

liranmauda

LGTM

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>

pull-request-size bot added the size/L label Nov 13, 2023

romayalon force-pushed the romy-access-keys-link branch 4 times, most recently from 7fcf68d to b8a4c3d Compare November 13, 2023 16:30

romayalon mentioned this pull request Nov 13, 2023

Issues identified in the Account update command #7549

Closed

romayalon force-pushed the romy-access-keys-link branch from b8a4c3d to 054bf8a Compare November 13, 2023 17:16

pull-request-size bot added size/XL and removed size/L labels Nov 13, 2023

naveenpaul1 reviewed Nov 14, 2023

View reviewed changes

src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved

src/cmd/manage_nsfs.js Show resolved Hide resolved

src/cmd/manage_nsfs.js Show resolved Hide resolved