Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NC | NSFS] Fix NSFS prometheus write bytes #7602

Conversation

tangledbytes
Copy link
Member

Explain the changes

This PR fixes missing write bytes from the prometheus metrics

Example

# HELP NooBaa_Endpoint_hub_read_bytes hub read bytes in namespace cache bucket
# TYPE NooBaa_Endpoint_hub_read_bytes counter
NooBaa_Endpoint_hub_read_bytes{bucket_name="first.bucket"} 899606

# HELP NooBaa_Endpoint_hub_write_bytes hub write bytes in namespace cache bucket
# TYPE NooBaa_Endpoint_hub_write_bytes counter
NooBaa_Endpoint_hub_write_bytes{bucket_name="first.bucket"} 1349409

NOTE: This PR was tested with #7562 as well.

Issues: Fixed #xxx / Gap #xxx

Previously, prometheus metrics lacked write bytes related info.

Testing Instructions:

  1. Start NooBaa (NSFS) with metrics server
  2. Open the webpage and find the write bytes as mentioned in the above example.
  • Doc added/updated
  • Tests added

Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com>
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangledbytes tangledbytes merged commit a6cdd20 into noobaa:master Nov 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants