-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NC | NSFS | Health script missing features #7603
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveenpaul1
force-pushed
the
nsfs_health_update
branch
from
November 16, 2023 12:15
eac4e9a
to
c8714cc
Compare
romayalon
reviewed
Nov 19, 2023
naveenpaul1
force-pushed
the
nsfs_health_update
branch
from
November 20, 2023 05:42
c8714cc
to
1f4767d
Compare
romayalon
reviewed
Nov 20, 2023
naveenpaul1
force-pushed
the
nsfs_health_update
branch
2 times, most recently
from
November 21, 2023 10:11
291d560
to
f7a4287
Compare
naveenpaul1
force-pushed
the
nsfs_health_update
branch
4 times, most recently
from
November 27, 2023 07:27
e945fba
to
3114072
Compare
romayalon
reviewed
Nov 27, 2023
@naveenpaul1 let's try to create a full schema of the health script response so we can get feedback |
naveenpaul1
force-pushed
the
nsfs_health_update
branch
2 times, most recently
from
November 28, 2023 10:16
1cb4c6f
to
c64fc5c
Compare
romayalon
reviewed
Nov 29, 2023
romayalon
reviewed
Nov 29, 2023
naveenpaul1
force-pushed
the
nsfs_health_update
branch
2 times, most recently
from
November 29, 2023 17:46
9ea7f7c
to
71f2c81
Compare
Signed-off-by: naveenpaul1 <napaul@redhat.com>
naveenpaul1
force-pushed
the
nsfs_health_update
branch
from
November 30, 2023 05:05
71f2c81
to
3829e1f
Compare
romayalon
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
{"service_name":"nsfs","status":"NOTOK","memory":"88.6M","error":{"error_code":"RSYSLOG_SERVICE_FAILED","error_message":"RSYSLOG service is not started properly, Please verify the service with status command."},"checks":{"services":[{"name":"nsfs","service_status":"active","pid":"1204"},{"name":"rsyslog","service_status":"inactive","pid":"0"}],"endpoint":{"endpoint_state":{"response":{"response_code":200,"response_message":"Endpoint running successfuly."},"total_fork_count":0,"running_workers":[]}},"invalid_accounts":[{"name":"naveen","storage_path":"/tmp/nsfs_root_invalid/","code":"STORAGE_NOT_EXIST"}],"valid_accounts":[{"name":"naveen","storage_path":"/tmp/nsfs_root"}],"invalid_buckets":[{"name":"bucket1.json","config_path":"/etc/noobaa.conf.d/buckets/bucket1.json","code":"INVALID_CONFIG"},{"name":"bucket3","storage_path":"/tmp/nsfs_root/bucket3","code":"STORAGE_NOT_EXIST"}],"valid_buckets":[{"name":"bucket2","storage_path":"/tmp/nsfs_root/bucket2"}]}}
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
node usr/local/noobaa-core/src/cmd/health.js
and each health check is correct against the running nsfs process.