Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | NSFS | Health script missing features #7603

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Nov 16, 2023

Explain the changes

  1. Add documentation output to the health section in docs
  2. Add to health test -
  • bucket check - iterate all buckets, and check bucket path exists like in namespace monitor
  • account check - iterate all accounts, and check account configuration exists, new_buckets_path exists
  1. remove unwanted logs from output
  2. add check for rsyslog
    {"service_name":"nsfs","status":"NOTOK","memory":"88.6M","error":{"error_code":"RSYSLOG_SERVICE_FAILED","error_message":"RSYSLOG service is not started properly, Please verify the service with status command."},"checks":{"services":[{"name":"nsfs","service_status":"active","pid":"1204"},{"name":"rsyslog","service_status":"inactive","pid":"0"}],"endpoint":{"endpoint_state":{"response":{"response_code":200,"response_message":"Endpoint running successfuly."},"total_fork_count":0,"running_workers":[]}},"invalid_accounts":[{"name":"naveen","storage_path":"/tmp/nsfs_root_invalid/","code":"STORAGE_NOT_EXIST"}],"valid_accounts":[{"name":"naveen","storage_path":"/tmp/nsfs_root"}],"invalid_buckets":[{"name":"bucket1.json","config_path":"/etc/noobaa.conf.d/buckets/bucket1.json","code":"INVALID_CONFIG"},{"name":"bucket3","storage_path":"/tmp/nsfs_root/bucket3","code":"STORAGE_NOT_EXIST"}],"valid_buckets":[{"name":"bucket2","storage_path":"/tmp/nsfs_root/bucket2"}]}}

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/MCGI-216

Testing Instructions:

  1. run node usr/local/noobaa-core/src/cmd/health.js and each health check is correct against the running nsfs process.
  • Doc added/updated
  • Tests added

src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
docs/non_containerized_NSFS.md Outdated Show resolved Hide resolved
src/cmd/health.js Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
@naveenpaul1 naveenpaul1 force-pushed the nsfs_health_update branch 2 times, most recently from 291d560 to f7a4287 Compare November 21, 2023 10:11
@naveenpaul1 naveenpaul1 force-pushed the nsfs_health_update branch 4 times, most recently from e945fba to 3114072 Compare November 27, 2023 07:27
docs/non_containerized_NSFS.md Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
@romayalon
Copy link
Contributor

@naveenpaul1 let's try to create a full schema of the health script response so we can get feedback

@naveenpaul1 naveenpaul1 force-pushed the nsfs_health_update branch 2 times, most recently from 1cb4c6f to c64fc5c Compare November 28, 2023 10:16
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/endpoint/endpoint.js Outdated Show resolved Hide resolved
src/endpoint/endpoint.js Outdated Show resolved Hide resolved
src/endpoint/endpoint.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
src/cmd/health.js Outdated Show resolved Hide resolved
@naveenpaul1 naveenpaul1 force-pushed the nsfs_health_update branch 2 times, most recently from 9ea7f7c to 71f2c81 Compare November 29, 2023 17:46
Signed-off-by: naveenpaul1 <napaul@redhat.com>
@naveenpaul1 naveenpaul1 merged commit 0a22925 into noobaa:master Nov 30, 2023
8 of 9 checks passed
@romayalon romayalon removed their assignment May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants