New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | move /etc/noobaa.conf.d/.env location to /etc/sysconfig/noobaa and redirect file read addition #7606

Merged

romayalon merged 1 commit into noobaa:master from romayalon:romy-redirect-file-change

Dec 3, 2023

Contributor

romayalon commented Nov 19, 2023 •

edited

Explain the changes

This is the first part of the new configuration -

nsfs.js - read /etc/noobaa.conf.d/config_dir_redirect and update the path appears in this file as config_root.
nsfs.service - replace .env location - /etc/noobaa.conf.d/.env with -/etc/sysconfig/noobaa
updated docs

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

Upgrade was tested manually

Doc added/updated
Tests added

pull-request-size bot added the size/M label

naveenpaul1 reviewed

View reviewed changes

docs/non_containerized_NSFS.md Outdated Show resolved Hide resolved

docs/non_containerized_NSFS.md Outdated Show resolved Hide resolved

romayalon force-pushed the romy-redirect-file-change branch from 389c76d to 735a63b Compare

November 20, 2023 08:27

pull-request-size bot added size/L and removed size/M labels

romayalon force-pushed the romy-redirect-file-change branch from a31d933 to ea366b8 Compare

November 23, 2023 14:51

naveenpaul1 approved these changes

View reviewed changes

Contributor

naveenpaul1 left a comment

Small comment,
LGTM

src/deploy/noobaa_nsfs.service Show resolved Hide resolved


          change env location and add redirect file

ed774af

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>

romayalon force-pushed the romy-redirect-file-change branch from ea366b8 to ed774af Compare

December 3, 2023 09:38

romayalon merged commit 69b7532 into noobaa:master

8 of 9 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment