Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | CLI | create config dirs if they don't exists #7610

Merged
merged 1 commit into from
Nov 21, 2023
Merged

NSFS | NC | CLI | create config dirs if they don't exists #7610

merged 1 commit into from
Nov 21, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. create config dirs if they don't exists at the beginning of manage_nsfs and in create_config_file and before symlinking access_key to account

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon
create config dirs if they don't exists
9b51b05 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
liranmauda
liranmauda approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, with one comment

src/cmd/manage_nsfs.js Show resolved Hide resolved
@romayalon romayalon merged commit 6e1a4b1 into noobaa:master Nov 21, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @liranmauda