parameterize centos base image version #7611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liranmauda
reviewed
Nov 21, 2023
alphaprinz
force-pushed
the
parameterize_base_image_version
branch
2 times, most recently
from
3060d74
to
b316384
Compare
liranmauda
approved these changes
Nov 21, 2023
2 tasks
Add a new Makefile param CENTOS_VER. Possible values are 8 and 9, default is 9. Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
alphaprinz
force-pushed
the
parameterize_base_image_version
branch
from
b316384
to
468fe8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
1.make noobaa CENTOS_VER=[8,9]
(default is 9)