Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | remove stat from verify_gpfs_lib() #7617

Merged
merged 1 commit into from
Nov 27, 2023
Merged

NSFS | NC | remove stat from verify_gpfs_lib() #7617

merged 1 commit into from
Nov 27, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. verify_gpfs_lib() had a stat(GPFS_DL_PATH) call which caused EINVAL error. The stat(GPFS_DL_PATH) is actually not needed because stat(GPFS_DL_PATH) is already being called on the initialization of fs_napi.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. tested manually by @janfrode (thanks Jan!)
  • Doc added/updated
  • Tests added

@romayalon
remove stat
62738d6 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
naveenpaul1
naveenpaul1 approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon romayalon merged commit b741676 into noobaa:master Nov 27, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @naveenpaul1