Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | CLI | read and write permissions of config subdirs and file fix and other small fixes #7624

Merged
merged 1 commit into from
Dec 5, 2023
Merged

NSFS | NC | CLI | read and write permissions of config subdirs and file fix and other small fixes #7624

merged 1 commit into from
Dec 5, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Nov 28, 2023 •
edited

Explain the changes

  1. CLI + Bucketspace_fs.js - Set 0o600 and 0o700 to config dirs or files on creation and update.
  2. CLI - validate bucket names on creation and update
  3. CLI - throw error on invalid type (not account/bucket) and on invalid action ( not add,list,update,status,delete)
  4. CLI - replace old non native().fs readdir / read
  5. Added CLI unit tests

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/MCGI-213
  2. Fixed #Noobaa bucket add command is not following AWS bucket naming rules #7612

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon mentioned this pull request Nov 28, 2023
Closed
naveenpaul1
naveenpaul1 approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment,
LGTM

src/cmd/manage_nsfs.js Show resolved Hide resolved
src/cmd/manage_nsfs.js Show resolved Hide resolved
@romayalon romayalon force-pushed the romy-nsfs-cleanups branch 3 times, most recently from a37ac46 to 7dd2325 Compare December 5, 2023 07:47
@romayalon
cli permissions and other fixes
7e5ffec 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit a2c631e into noobaa:master Dec 5, 2023
8 of 9 checks passed
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @naveenpaul1