Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade packages. Bypass google stroage UserAgent rewrite. #7627

Merged
merged 1 commit into from
Dec 4, 2023
Merged

upgrade packages. Bypass google stroage UserAgent rewrite. #7627

merged 1 commit into from
Dec 4, 2023

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

  1. Upgrade packages.

Issues: Fixed #xxx / Gap #xxx

  1. Google's cloud storage package doesn't export a used function anymore.

Testing Instructions:

  1. make tests
  • Doc added/updated
  • Tests added

liranmauda
liranmauda approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@liranmauda liranmauda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alphaprinz
upgrade packages. Bypass google stroage UserAgent rewrite.
9d1786a 
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
@alphaprinz alphaprinz marked this pull request as ready for review December 4, 2023 08:33
@alphaprinz alphaprinz merged commit 2c728eb into noobaa:master Dec 4, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyzaken dannyzaken dannyzaken approved these changes

@liranmauda liranmauda liranmauda approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alphaprinz @dannyzaken @liranmauda