Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Update system.json structure + small redirect fix #7638

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Dec 3, 2023

Explain the changes

  1. Since system.json might be shared between hosts we need to update the system.json structure to reflect the system per hostname.
    The new structure is of the following format -
{
  'hostname1': {
    current_version: '5.15.2',
    upgrade_history: { successful_upgrades: [ { timestamp: 1701619673797, completed_scripts: [], from_version: '5.15.1', to_version: '5.15.2' } ] }
  }, 
'hostname2': {
    current_version: '5.15.2',
    upgrade_history: { successful_upgrades: [ { timestamp: 1701619673797, completed_scripts: [], from_version: '5.15.1', to_version: '5.15.2' } ] }
  }
}
  1. Added a small redirect fix

Issues: Fixed #xxx / Gap #xxx

  1. TODO: we need to handle concurrent upgrades of multiple hosts.

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon romayalon changed the title NSFS | NC | Update system.json structure NSFS | NC | Update system.json structure + small redirect fix Dec 3, 2023
Copy link
Member

@tangledbytes tangledbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to probably document that in a cluster each host should have a unique name.

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 5ace1aa into noobaa:master Dec 4, 2023
8 of 9 checks passed
@romayalon
Copy link
Contributor Author

@tangledbytes I added this limitation in docs, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants