New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | CLI | Remove unwanted console logs for manage NSFS script #7640

Merged

naveenpaul1 merged 1 commit into noobaa:master from naveenpaul1:nsfs_cli_console

Dec 7, 2023

Contributor

naveenpaul1 commented Dec 5, 2023 •

edited

Explain the changes

Remove unwanted console logs for manage NSFS script

Issues: Fixed #xxx / Gap #xxx

creation_date is missing bucket
CLI argument validation issue for account and bucket
unit test for managing CLI
error and success messages updated
CLI validation issue fixed
health nsfs service name change to noobaa_nsfs

Note: log printing to stderr changes are not included.

Testing Instructions:

run both account and bucket operations

Doc added/updated
Tests added

naveenpaul1 requested review from jackyalbo, liranmauda and romayalon

December 5, 2023 06:14

pull-request-size bot added the size/L label

naveenpaul1 mentioned this pull request

NSFS | NC | CLI | Remove unwanted console logs for manage NSFS script #7636

Closed

2 tasks

naveenpaul1 force-pushed the nsfs_cli_console branch 7 times, most recently from b581760 to f6d66d6 Compare

December 6, 2023 10:33

romayalon reviewed

View reviewed changes

src/server/object_services/schemas/nsfs_bucket_schema.js Show resolved Hide resolved

naveenpaul1 force-pushed the nsfs_cli_console branch 2 times, most recently from 27ce862 to f56091e Compare

December 7, 2023 05:23

romayalon approved these changes

View reviewed changes

Contributor

romayalon left a comment

2 lasts comments and let's merge :)

docs/non_containerized_NSFS.md Show resolved Hide resolved

src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved


          NSFS | NC | CLI | Remove unwanted console logs

f4553d1

skip console.warn() from config.js load call

Signed-off-by: naveenpaul1 <napaul@redhat.com>

naveenpaul1 force-pushed the nsfs_cli_console branch from f56091e to f4553d1 Compare

December 7, 2023 07:56

naveenpaul1 merged commit d08cf47 into noobaa:master

8 of 9 checks passed

romayalon mentioned this pull request

Warning and console messages should not be visible on execution of any commands accounts/bucket/config #7628

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment