Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | CLI | Update config root default of manage_nsfs and health #7641

Merged
merged 1 commit into from
Dec 5, 2023
Merged

NSFS | NC | CLI | Update config root default of manage_nsfs and health #7641

merged 1 commit into from
Dec 5, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. update config root default to be evaluated from config.js instead of directly default value (can take path from config_dir_redirect file or config.NSFS_NC_DEFAULT_CONF_DIR.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon
update config_root_default of manage_nsfs and health
357e6ff 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon force-pushed the romy-update-config-dir-of-clis branch from f7a5350 to 357e6ff Compare December 5, 2023 12:19
@romayalon romayalon merged commit 756e5ee into noobaa:master Dec 5, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackyalbo jackyalbo jackyalbo approved these changes

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @jackyalbo