Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | fix type of ports in nsfs config schema #7643

Merged
merged 1 commit into from
Dec 6, 2023
Merged

NSFS | NC | fix type of ports in nsfs config schema #7643

merged 1 commit into from
Dec 6, 2023

Conversation

romayalon
Copy link
Contributor

@romayalon romayalon commented Dec 6, 2023 •
edited

Explain the changes

  1. fix type of ports in nsfs config schema
  2. change on rpm install the systemd noobaa_nsfs.service from symbolic link to hard link so it won't be deleted on systemctl disable noobaa_nsfs

Issues: Fixed #xxx / Gap #xxx

  1. should fix After disabling the noobaa service, it removes the service permanently. Thus not able to start later on #7621

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon
fxi ports type in schema
5ad3292 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon mentioned this pull request Dec 6, 2023
Closed
@romayalon romayalon merged commit f17c19f into noobaa:master Dec 6, 2023
8 of 9 checks passed
@romayalon romayalon mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alphaprinz alphaprinz alphaprinz approved these changes

@naveenpaul1 naveenpaul1 Awaiting requested review from naveenpaul1

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After disabling the noobaa service, it removes the service permanently. Thus not able to start later on
2 participants
@romayalon @alphaprinz