Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Add white list IP table support for S3 #7653

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

naveenpaul1
Copy link
Contributor

@naveenpaul1 naveenpaul1 commented Dec 8, 2023

Explain the changes

  1. Noobaa should get the CES IP and have a white list in order to allow only incoming requests from a given list of IPs - not having it is a security issue from Spectrum scale perspective

doc : https://ibm.ent.box.com/file/1379004287366?s=bit6jatl19fbmfcov7ldyszoc4ttnbka

Issues: Fixed #xxx / Gap #xxx

  1. https://issues.redhat.com/browse/MCGI-209

Testing Instructions:

  • Doc added/updated
  • Tests added

@naveenpaul1 naveenpaul1 force-pushed the nsfs_whitelist branch 4 times, most recently from 9e9b295 to 4434ab3 Compare December 11, 2023 11:29
@naveenpaul1 naveenpaul1 marked this pull request as ready for review December 11, 2023 11:35
src/util/http_utils.js Outdated Show resolved Hide resolved
src/test/unit_tests/test_nc_nsfs_cli.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Show resolved Hide resolved
src/util/http_utils.js Outdated Show resolved Hide resolved
Signed-off-by: naveenpaul1 <napaul@redhat.com>

PR revew comment

Signed-off-by: naveenpaul1 <napaul@redhat.com>
@naveenpaul1 naveenpaul1 merged commit 9b23187 into noobaa:master Dec 18, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants