Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node20 - workaround for ping #7658

Merged
merged 1 commit into from
Dec 13, 2023
Merged

node20 - workaround for ping #7658

merged 1 commit into from
Dec 13, 2023

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

  1. The "net-ping" package is outdated. It has, as a dependency, package "nan" with old version that doesn't compile with node20.
    This commit exchange the "net-ping" package with "ping" package which seems better maintained.

Issues: Fixed #xxx / Gap #xxx

  1. Prepare to upgrade to node20.

Testing Instructions:

  • Doc added/updated
  • Tests added

@alphaprinz
node20 - workaround for ping
77cd4c0 
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
@alphaprinz alphaprinz merged commit 9030365 into noobaa:master Dec 13, 2023
8 of 9 checks passed
liranmauda pushed a commit to liranmauda/noobaa-core that referenced this pull request Dec 20, 2023
@alphaprinz @liranmauda
node20 - workaround for ping (noobaa#7658)
467f640 
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
(cherry picked from commit 9030365)
liranmauda pushed a commit to liranmauda/noobaa-core that referenced this pull request Dec 20, 2023
@alphaprinz @liranmauda
node20 - workaround for ping (noobaa#7658)
6d19c58 
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
(cherry picked from commit 9030365)
liranmauda pushed a commit to liranmauda/noobaa-core that referenced this pull request Dec 20, 2023
@alphaprinz @liranmauda
node20 - workaround for ping (noobaa#7658)
e71aae8 
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
(cherry picked from commit 9030365)
Signed-off-by: liranmauda <liran.mauda@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liranmauda liranmauda liranmauda approved these changes

@guymguym guymguym Awaiting requested review from guymguym

@shirady shirady Awaiting requested review from shirady

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alphaprinz @liranmauda