Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSFS | NC | add root permission requirement for health and manage scripts #7661

Merged
merged 1 commit into from
Dec 18, 2023
Merged

NSFS | NC | add root permission requirement for health and manage scripts #7661

merged 1 commit into from
Dec 18, 2023

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. As discussed at the latest HPO meeting, we should require root permissions for manage_nsfs execution, also sounds like we won't be able to run health without it as well.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@romayalon
add root permission requirement for health and manage scripts
28e496e 
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
naveenpaul1
naveenpaul1 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@naveenpaul1 naveenpaul1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romayalon romayalon merged commit 1f6ccd0 into noobaa:master Dec 18, 2023
8 of 9 checks passed
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naveenpaul1 naveenpaul1 naveenpaul1 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@romayalon @naveenpaul1