Backport to 5.15 #7712
Merged
Backport to 5.15 #7712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the NC Ceph tests (not NSFS) we had a “|| true” part after the run that was leftover from running it in the k8s job that we always wanted to complete successfully, in the new platform it is not relevant. Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 1173899) Signed-off-by: Nimrod Becker <bnimrod@gmail.com>
Signed-off-by: naveenpaul1 <napaul@redhat.com> (cherry picked from commit 3b0eb18) Signed-off-by: Nimrod Becker <bnimrod@gmail.com>
Signed-off-by: jackyalbo <jacky.albo@gmail.com> (cherry picked from commit ab913e2) Signed-off-by: Nimrod Becker <bnimrod@gmail.com>
by running eslint src --fix Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 42d9360) Signed-off-by: Nimrod Becker <bnimrod@gmail.com>
1. Move the NC NSFS schema validation that we had in file `src/sdk/bucketspace_fs.js` (from PR noobaa#7544) to a separate file (`src/manage_nsfs/nsfs_schema_utils.js`) to reuse it. 2. Edit the values of `s3_policy` and `fs_backend` to be undefined (and not empty `''`, as it passed as an argument). 3. Validate the data using schema and return an error in case it doesn't match (details would be passed according to the original message), using a mapping `ManageCLIError.RPC_ERROR_TO_MANAGE`. 4. Update the unit tests for the cases of `s3_policy` and `fs_backend` deletions (separate the argument that we pass as `''` to the actual property that would be `undefined`). 5. Change the `uid` and `gid` extract in function `fetch_account_data` to be `undefined` when the argument user was passed (and not `false`). 6. Use `schema_utils.strictify` with option `additionalProperties: false` in the `nsfs_account_schema` and `nsfs_bucket_schema`. 7. Add the `versioning` enum to the bucket schema. 8. Add tests for the schema validation of nsfs_account_schema and nsfs_bucket_schema. Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 4d11e6b) Signed-off-by: Nimrod Becker <bnimrod@gmail.com>
romayalon
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes