BACKPORT 5.15 #7749
Merged
BACKPORT 5.15 #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 947d886)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit bb69ce7)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit b8e455c)
1. Add schema validation: create_bucket, set_bucket_versioning, put_bucket_encryption, put_bucket_policy, put_bucket_website. For the delete cases code was changed to delete property instead of assignment to undefined, and still added the schema validation for the safe side (delete_bucket_encryption, delete_bucket_policy, delete_bucket_website 2. Add encryption and website to nsfs_bucket_schema. 3. Edit the tag property in nsfs_bucket_schema to use the existing definition. 4. Update existing tests to match the schema. 5. Add new tests for the changes in the schema. 6. Refactor Jest tests for schema validation (separate files, use a mutual function for bucket and account, reuse function for assertion of fail, etc.). 7. Update documentation NonContainerizedNSFSDesign.md related to the schema changes (account, bucket). Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 9b8a4e7)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit cf8ff10)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit a657fb1)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 97f2e27)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 0bd0f40)
by running eslint src --fix Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 072b4d4)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit e251251)
…ent errors Signed-off-by: naveenpaul1 <napaul@redhat.com> (cherry picked from commit b2d1d23)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit 703b7d1)
1. Create help printing for each action. 2. Move the const TYPES and ACTIONS to a different file (for reuse). 3. Fix the FS backend types in help menu and error to: GPFS | CEPH_FS | NFSv4 (NFSv4 instead of NFV_V4). Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit e7d66ed)
Signed-off-by: jackyalbo <jacky.albo@gmail.com> (cherry picked from commit 7916a6d)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 7f840cf)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit d17460b)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit 4992d70)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit c31ee61)
Signed-off-by: naveenpaul1 <napaul@redhat.com> (cherry picked from commit a90e40d)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit c2ae569)
Signed-off-by: naveenpaul1 <napaul@redhat.com> (cherry picked from commit bf13a45)
Signed-off-by: naveenpaul1 <napaul@redhat.com> (cherry picked from commit 7318fdc)
liranmauda
approved these changes
Jan 23, 2024
nimrod-becker
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: