[Backport to 5.15] fixed signature calculations for cpp aws-sdk #7840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* AWS SDK for C++ sends the '=' character unencoded when it is in the "key" string but calculates the signature for the encoded '%3D' value. * fixed `function _aws_request` to first decode the pathname (to avoid reencoding of '%' characters) and then encode the path again. Signed-off-by: Danny Zaken <dannyzaken@gmail.com> added signature tests Signed-off-by: Danny Zaken <dannyzaken@gmail.com> (cherry picked from commit ccf16e3) Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
nimrod-becker
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit ccf16e3)
Explain the changes
function _aws_requestto first decode the pathname (to avoid reencoding of '%' characters) and then encode the path again.Issues: Fixed #xxx / Gap #xxx
Testing Instructions: