Backport to 5.15.1 NS FS fixes #7884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimrod-becker
changed the title
nimrod-becker
force-pushed
the
backport_to_5_15
branch
from
454f240
to
6f7ed79
Compare
|
Please dont merge at this point. |
|
Looks good from WAL fixes POV ✅ |
|
Looks good for health and random seed changes. ✅ |
nimrod-becker
changed the title
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit 408eca8)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit ca9b562)
Signed-off-by: naveenpaul1 <napaul@redhat.com> (cherry picked from commit 1d24f60)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit 2778480)
1. Remove the string or number and only handle names and allow it to be a number. 2. Check that the argument is not empty directly with argv array (and not object my minimist). 3. Rename the function from "options' to "flags" to be aligned with customer terms when referring to the raw input from the user. 4. Remove option validation from from-file (will be a GAP). Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 28165db)
…update) Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit c2e6a42)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 2f5d4d5)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit fdc5f6c)
1. Remove SensitiveStrings from all properties except secret_access_key and access_key in manage_nsfs. 2. Remove SensitiveString from nsfs_account_config.distinguished_name inside get_fs_context (native_fs_utils). Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 20bb4dd)
Signed-off-by: naveenpaul1 <napaul@redhat.com> (cherry picked from commit 35dcf07)
adding special handling in case of getting too many forks exits in a given time frame adding read_bucket_sdk_config_info to remove errors when running nsfs in simple mode Signed-off-by: jackyalbo <jacky.albo@gmail.com> (cherry picked from commit b11b17d)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit c07999d)
- Copy noobaa_syslog.conf as a regular file instead of a symlink - Do not copy noobaa_rsyslog.conf at the rpm install - Move tilestamp format definition from noobaa_rsyslog.conf to noobaa_syslog.conf - Update 'non_containerized_NSFS.md' because noobaa_rsyslog.conf is not needed in the standalone env - Copy the unit file of systemd to /usr/lib/systemd/system Signed-off-by: Atsushi Abe <piste@jp.ibm.com> (cherry picked from commit 880e29f)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit e027008)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit d4264be)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit c9bcccd)
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> (cherry picked from commit 278e3ad)
…licitly 1. Add a flag to change the value of allow_bucket_creation. 2. Edit details message when BucketCreationNotAllowed is thrown. 3. Add the option for boolean flags to pass 'true' and 'false' (wide, show_secrets, regenerate). 4. Add a new error InvalidBooleanValue. 5. Reduce the number of spaces in the help menu. Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 57474ee)
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com> (cherry picked from commit 1e6a51c)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 0d17ba6)
1. Add the from_file option in the account that would include validation. The JSON file will include options (as key-value structure) that are the same as the flags we suggest. 2. Change the structure inside the main so that eventually it doesn't matter whether the parameters are from the flags arguments (argv) or file. 3. Move get_access_keys to a separate function. 4. Fix indentation in fetch_account_data in the part of access_key as SensitiveString. 5. Remove an unused parameter from validate_options_type_by_value. 6. In native_fs_utils.js rename the function read_config_file to read_file. 7. Update json in doc so _id will appear first (as fixed in this PR). Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit 0796e79)
Signed-off-by: shirady <57721533+shirady@users.noreply.github.com> (cherry picked from commit a2b60be)
Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix WAL processing failures Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> don't swallow the error on init Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> prevent file truncation upon open Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> set default fd to -1 and set fd to -1 after close Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> simplify persistent log entry interface Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> replace fd 0 with -1 Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> handle the edge case of empty WAL file processing Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix file filtering on WALs Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> close iff fd > 0 Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> remove flags doc from glacier commands Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> update glacier docs style Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add tests for GLACIER Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix assertions Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> fix test Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add logging to tapecloud processing Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> don't explicitly rely on -1 as FD Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> skip migration for files which have 0 blocks Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> change the log dir structure Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> add regex to ctor Signed-off-by: Utkarsh Srivastava <srivastavautkarsh8097@gmail.com> (cherry picked from commit cf44761)
Signed-off-by: naveenpaul1 <napaul@redhat.com> (cherry picked from commit 6e34788) fix lint
nimrod-becker
force-pushed
the
backport_to_5_15
branch
from
6f7ed79
to
a6a2ae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes