Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSFS | NC | Refactor Bucketspace_fs.delete_bucket() and others #7938

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. Refactored delete_bucket() function in 2 aspects -
    • Bucketspace_fs.js -
      - The 3 (different functions) calls to namespace_bucket_cache functions
      were merged to a new function call that returns bucket and ns info.
      - Moved inline tmpdir path to a function in native_fs_utils (called this function from other places as well)
    • object_sdk.js - Added a new function called read_bucket_full_info().
    • native_fs_utils.js -
      - Added 2 new functions called get_bucket_tmpdir_full_path() and get_bucket_tmpdir_name() and changed the calls from different files to re-use this code block.
    • namespace_fs.js -
      - Renamed get_bucket_tmpdir() to get_bucket_tmpdir_name() and changed the
      implementation to call the native_fs_utils function.
      - Added get_bucket_tmpdir_full_path() to call the compatible native_fs_utils.js function with the namespace bucket_path and bucket_id.

VSC error fixes -

  • bucketspace_simple_fs.js -
    - Added missing put_bucket_logging(), get_bucket_logging(), delete_bucket_logging() function declerations (unimplemented).
    - Added function declaretions to delete_bucket() and get_bucket_website()

  • nb.d.ts - Added a new type NativeFSUserObject and added it to the return value of getpwname() (fixed errors in test_bucketspace_fs.js)

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

@guymguym guymguym modified the milestones: 5.15.4, 5.16.0 Apr 22, 2024
@romayalon romayalon force-pushed the romy-delete-bucket-perf branch 2 times, most recently from f381ef1 to 6a9e372 Compare May 13, 2024 06:43
@romayalon romayalon force-pushed the romy-delete-bucket-perf branch 2 times, most recently from 4ff0ff3 to aa1baf7 Compare June 16, 2024 09:54
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit b1aa754 into noobaa:master Jun 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants