NSFS | Logrotate is not performing for noobaa logs #7998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveenpaul1
force-pushed
the
logrotate_not_working
branch
from
48f9f5e
to
95e2770
Compare
guymguym
requested changes
May 3, 2024
naveenpaul1
force-pushed
the
logrotate_not_working
branch
from
95e2770
to
2deee57
Compare
aspandey
reviewed
May 6, 2024
naveenpaul1
force-pushed
the
logrotate_not_working
branch
from
2deee57
to
176c310
Compare
naveenpaul1
force-pushed
the
logrotate_not_working
branch
3 times, most recently
from
761cf09
to
f393237
Compare
aspandey
reviewed
May 6, 2024
naveenpaul1
force-pushed
the
logrotate_not_working
branch
from
f393237
to
d399e5b
Compare
guymguym
reviewed
May 6, 2024
naveenpaul1
force-pushed
the
logrotate_not_working
branch
from
d399e5b
to
2a7b32f
Compare
guymguym
reviewed
May 6, 2024
naveenpaul1
force-pushed
the
logrotate_not_working
branch
from
2a7b32f
to
8f4ce60
Compare
guymguym
reviewed
May 6, 2024
guymguym
reviewed
May 6, 2024
naveenpaul1
force-pushed
the
logrotate_not_working
branch
2 times, most recently
from
dcf3e74
to
ea5c177
Compare
guymguym
reviewed
May 7, 2024
guymguym
reviewed
May 7, 2024
naveenpaul1
force-pushed
the
logrotate_not_working
branch
2 times, most recently
from
de2b20b
to
71b2eb5
Compare
guymguym
approved these changes
May 8, 2024
There was a problem hiding this comment.
Minor fix suggested to docs.
Looks good!
Thanks for the hard work on this.
Remember to create an issue for technical gap to "NC | syslogs are sent twice" - Since debug_module sends every log message to two targets (but native code logs only to stderr at the moment) -
- syslog facility local0 - then rsyslog omfile copies it to
/var/log/noobaa.log - stdout/stderr - then systemd copies it into its journal and then rsyslog imjournal copies it to the file
/var/log/messages.
Signed-off-by: naveenpaul1 <napaul@redhat.com>
naveenpaul1
force-pushed
the
logrotate_not_working
branch
from
71b2eb5
to
c0d0167
Compare
This was referenced May 9, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: