Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | set noobaa as endpoint process title #8095

Merged
merged 1 commit into from
May 30, 2024

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. setting process title needed for letting GPFS to identify the noobaa endpoint processes see issue NSFS | when FS is unavailable requests fail immediately with InternalError exhausting client attempts #8039.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed NSFS endpoint should set its process/threads name in the OS to be identified accurately #8049

Testing Instructions:

Manual Testing -

  1. Tab 1 - Run sudo node src/cmd/nsfs.js --debug=5
  2. Tab 2 - Run ps -e | grep noobaa and expect 1 result.
  3. Try setting ENDPOINT_FORKS = 3 in config.json and expect 4 results of step 2.
% ps -e | grep noobaa
14536 ttys000    0:03.04 noobaa
14539 ttys000    0:03.28 noobaa
14540 ttys000    0:03.43 noobaa
14541 ttys000    0:03.31 noobaa
14563 ttys005    0:00.00 grep --color=auto noobaa
  • Doc added/updated
  • Tests added

@romayalon
Copy link
Contributor Author

@eshelmarc Could we check this oneliner on your machine?

src/endpoint/endpoint.js Outdated Show resolved Hide resolved
@guymguym guymguym added this to the 5.15.4 milestone May 29, 2024
@romayalon romayalon force-pushed the romy-native-process-name branch 2 times, most recently from 9579153 to ecaede5 Compare May 30, 2024 05:01
@romayalon romayalon requested a review from guymguym May 30, 2024 05:03
src/endpoint/endpoint.js Outdated Show resolved Hide resolved
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 540e84b into noobaa:master May 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSFS endpoint should set its process/threads name in the OS to be identified accurately
2 participants