Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | CLI | trimmed output fix #8117

Merged
merged 1 commit into from
Jun 9, 2024
Merged

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. A follow up to NSFS | NC | health giving trimmed output in pipe #7898, doing the same changes but for noobaa_cli.
  2. Had to move the stdout write on error to the catch scope of main() in manage_nsfs due to Noobaa health command giving trimmed output in pipe #7894.

Issues: Fixed #xxx / Gap #xxx

  1. Fixed Noobaa command to list bucket/account giving trimmed output in pipe  #8111
  2. We should consider making the same changes of bullet 2 for success flow (write_stdout_output).

Testing Instructions:

  1. env LC_ALL=C /usr/local/bin/noobaa-cli bucket 2>/dev/null list --wide
  • Doc added/updated
  • Tests added

@romayalon romayalon marked this pull request as ready for review June 6, 2024 17:37
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
src/cmd/manage_nsfs.js Outdated Show resolved Hide resolved
@romayalon romayalon force-pushed the romy-nc-trim-fix branch 2 times, most recently from 3b0b42f to 028d174 Compare June 9, 2024 05:00
@romayalon romayalon requested a review from guymguym June 9, 2024 05:03
Copy link
Member

@guymguym guymguym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small comment, otherwise looks good

Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 27b6939 into noobaa:master Jun 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Noobaa command to list bucket/account giving trimmed output in pipe
2 participants