Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC | Revert url encode/decode of xattr values #8129

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

romayalon
Copy link
Contributor

Explain the changes

  1. Revert code added in S3 | EncodeURIComponent / DecodeURIComponent xattr #7986
  2. Added try & catch that skips xattr headers that can not be set during setHeader() by assuming that xattrs that can be returned are coming through s3. If invalid xattrs were set directly on the file system and can not return through http header, the best behavior is not to fail the head object but to not return the invalid xattr. If customer wants to get invalid headers via s3 the xattr should be encoded on the file system if they are not us-ascii.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  • Doc added/updated
  • Tests added

src/endpoint/s3/s3_utils.js Outdated Show resolved Hide resolved
Signed-off-by: Romy <35330373+romayalon@users.noreply.github.com>
@romayalon romayalon merged commit 884cad0 into noobaa:master Jun 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants