New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added --dev flag to the cli #1094

Merged

dannyzaken merged 1 commit into noobaa:master from dannyzaken:danny-fixes

Apr 19, 2023

Contributor

dannyzaken commented Apr 19, 2023 •

edited

Explain the changes

added --dev flag to noobaa CLI
same as --mini but with higher resources requests tuned for a dev environment (mainly M1 macs)

Issues: Fixed #xxx / Gap #xxx

Fixes Add a flag for developer resource #1017

Testing Instructions:

Doc added/updated
Tests added

pull-request-size bot added the size/M label

dannyzaken requested review from a team, vh05 and liranmauda and removed request for a team

April 19, 2023 06:42

vh05 approved these changes

View reviewed changes

Contributor

vh05 left a comment

just the comment in wrong place. apart from that lgtm

liranmauda reviewed

View reviewed changes

Contributor

liranmauda left a comment

@dannyzaken Why should we keep the MiniEnv (--mini) flag?

pkg/options/options.go Outdated Show resolved Hide resolved

shirady reviewed

View reviewed changes

pkg/options/options.go Outdated Show resolved Hide resolved

pkg/options/options.go Outdated Show resolved Hide resolved

pkg/options/options.go Show resolved Hide resolved

Contributor

shirady commented Apr 19, 2023

General comment - I think it is an example of why we should run linters (make lint & golangci-lint ) separated from the tests themselves (we could see that it doesn't break anything and we have just a lint error about a comment).

Contributor

shirady commented Apr 19, 2023

@dannyzaken, would you please add this issue #1017 as fixed in the description?

Contributor Author

dannyzaken commented Apr 19, 2023

@dannyzaken Why should we keep the MiniEnv (--mini) flag?

it is used by our tests. at first I tried to increase the resources for --mini, but the images in the actions don't have enough resources

dannyzaken force-pushed the danny-fixes branch from fc9db73 to 2fd8b1d Compare

April 19, 2023 12:58

shirady reviewed

View reviewed changes

pkg/options/options.go Outdated Show resolved Hide resolved


          dded --dev flag to the cli

91483cd

Signed-off-by: Danny Zaken <dannyzaken@gmail.com>

dannyzaken force-pushed the danny-fixes branch from 2fd8b1d to 91483cd Compare

April 19, 2023 13:05

Contributor Author

dannyzaken commented Apr 19, 2023 •

edited

General comment - I think it is an example of why we should run linters (make lint & golangci-lint ) separated from the tests themselves (we could see that it doesn't break anything and we have just a lint error about a comment).

~~actually, for the operator we do have a separate action for the linter, but it passed. don't know what are the differences from the makefile one~~

Edit: actually these are different checks. I agree we should run them as a preliminary check

dannyzaken merged commit 5bbee99 into noobaa:master

12 checks passed

shirady mentioned this pull request

CI | Separate the Lint Checks from the Tests #1096

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment