Remove the default value of spec.store from ChepObjectStoreUser template #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nb-ohad
changed the title
For some reason kubeclient.Get will not remove/empty keys that do not exists in the CR instance. (which make it act a little bit like merge) For this reason, in the case where our code creates the ChepObjectStoreUser with an empty store name (independent mode), the next reconcile will refill the value from the template (the value will be STORE_NAME) Removing the value from the template will fix the issue
nb-ohad
force-pushed
the
ohad-cephobjectstoreuser-store-value-fix
branch
from
2fc0983
to
f82f644
Compare
jackyalbo
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason kubeclient.Get will not remove/empty keys that do not exists in the CR instance. (which make it act a little bit like merge)
For this reason, in the case where our code creates the ChepObjectStoreUser with an empty store name (independent mode), the next reconcile will refill the value from the template (the value will be STORE_NAME)
Removing the value from the template will fix the issue