Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket client - improve server disconnect detection #810

Merged
merged 1 commit into from Dec 8, 2021

Conversation

baum
Copy link
Contributor

@baum baum commented Dec 7, 2021

  • Implements WS ping heartbeat to improve server disconnect event
    detection
  • Add connect context timeout

Signed-off-by: Alexander Indenbaum aindenba@redhat.com

Explain the changes

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

- Implements WS ping heartbeat to improve server disconnect event
  detection
- Add connect context timeout

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
@baum baum marked this pull request as ready for review December 8, 2021 09:34
@baum baum requested a review from dannyzaken December 8, 2021 09:45
@baum baum merged commit 5648167 into noobaa:master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants