Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New board and serial protocol added #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gotchafr
Copy link

Arduino Mini + GY-521 + 3 pots
Warning: never flown yet, so be careful ;-)

Added Graupner SUMD protocol
Added
  SerialRX Graupner SUMD protocol
  Board Arduino Mini + GY-521 + 3 Pots
Added board: Arduino MINI + GY-521 + 3 pots
@noobee
Copy link
Owner

noobee commented May 12, 2014

hey

i looked at the changes and have two pieces of feedback:

  • would suggest that you create a branch for these changes. the reason that there are other changes that need to go in (eg flightstab.h and for the programmer) and we probably need to test it abit more. i can work on the changes for the programmer. so it's better to keep it in a (SUMD+GY521) branch before we commit it back to the master. sorry about the change of mind.
  • i noticed you uncommented USE_I2CDEVLIB. that is not the preferred default i2c library to use. we should use i2clight if possible. i'm also planning to deprecate the use of I2CDEVLIB since people don't usually download this library separately (one user on rcgroups had trouble compiling without it).

i'll respond to your other questions on the rcgroups pm.

thanks

@gotchafr
Copy link
Author

Hi noobee,

No problem, do whatever you feel is better.

Concerning the USE_I2CDEVLIB, I just forgot to comment it out. But I would certainly not deprecate it. In my opinion, it could open the way to more advanced use of the MPU or other sensors (just my two cents)

Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants