Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short delay to avoid blocking #9

Merged
merged 1 commit into from
May 25, 2021
Merged

Conversation

kasnder
Copy link
Contributor

@kasnder kasnder commented May 24, 2021

Usually, the script works very well for me. However, it blocks the main thread for me, and delays the start of the app. It also crashes for some apps.

The proposed change does two things:

  1. It does the class dumping asynchronously, so app loading isn't delayed anymore (I think).
  2. For a small number of very large apps (size more than 1GB, less than 1% of all apps), it prevents crashes, and failure of class dumping by delaying the class dumping operation.

@kasnder
Copy link
Contributor Author

kasnder commented May 24, 2021

I've only tested this using frida -U -f package -l script.js so far.

Update: Seems to work with the latest ./ioshook as well.

@noobpk
Copy link
Owner

noobpk commented May 25, 2021

Thank you very much for your contribution.
Sometimes scripts run too fast leading to app crashes. ^^!!

@noobpk noobpk merged commit c94ffcf into noobpk:master May 25, 2021
@kasnder kasnder deleted the patch-1 branch May 25, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants