chore(deps): update package deps, update mocha tests per warnings

package.json

@@ -9,25 +9,25 @@
   "dependencies": {
     "buffer-builder": "^0.2.0",
     "bl": "^1.1.2",
-    "bluebird": "^3.4.0",
+    "bluebird": "^3.4.1",
     "debug": "^2.2.0",
-    "lodash": "^4.13.1",
+    "lodash": "^4.15.0",
     "node-amqp-encoder": "^0.0.2",
     "node-int64": "^0.4.0",
     "stately.js": "^1.3.0",
     "uuid": "^2.0.2"
   },
   "devDependencies": {
-    "benchmark": "^2.1.0",
+    "benchmark": "^2.1.1",
     "chai": "^3.5.0",
     "chai-string": "^1.2.0",
     "conventional-changelog-cli": "^1.2.0",
-    "istanbul": "^0.4.3",
-    "jsdoc-to-markdown": "^1.3.6",
-    "jshint": "^2.9.2",
-    "mocha": "^2.5.3",
+    "istanbul": "^0.4.4",
+    "jsdoc-to-markdown": "^1.3.7",
+    "jshint": "^2.9.3",
+    "mocha": "^3.0.2",
     "qmf2": "^0.1.5",
-    "stream-buffers": "^3.0.0"
+    "stream-buffers": "^3.0.1"
   },
   "scripts": {
     "version": "make changelog && git add CHANGELOG.md"

test/integration/qpid/disposition.test.js

@@ -29,7 +29,8 @@ describe('Disposition', function() {
   it('should auto-settle messages received from queue', function(done) {
     var queueName = 'test.disposition.queue';
     var messageCount = 0;
-    return test.client.connect(config.address)
+
+    test.client.connect(config.address)
       .then(function() {
         test.broker = new BrokerAgent(test.client);
 
@@ -63,7 +64,7 @@ describe('Disposition', function() {
     var queueName = 'test.disposition.queue';
     var messageCount = 5, receivedCount = 0;
 
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         test.broker = new BrokerAgent(test.client);
         return Promise.all([
@@ -104,7 +105,8 @@ describe('Disposition', function() {
   it('should forward disposition frames by link role', function(done) {
     var queueName = 'test.disposition.queue';
     var called = { receiver: false, sender: false };
-    return test.client.connect(config.address)
+
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver(queueName),

test/integration/qpid/receiver_link.test.js

@@ -20,7 +20,7 @@ describe('ReceiverLink', function() {
   });
 
   it('should allow the definition of a default subject', function(done) {
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver('amq.topic/not-news'),
@@ -45,7 +45,7 @@ describe('ReceiverLink', function() {
     var throttledClient =
       new AMQPClient(Policy.Utils.RenewOnSettle(1, 1, Policy.Default));
 
-    return Promise.all([
+    Promise.all([
       test.client.connect(config.address),
       throttledClient.connect(config.address)
     ])

test/integration/qpid/sender_link.test.js

@@ -20,7 +20,7 @@ describe('SenderLink', function() {
   });
 
   it('should allow the definition of a default subject', function(done) {
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver('amq.topic/not-news'),
@@ -42,7 +42,7 @@ describe('SenderLink', function() {
   });
 
   it('should merge default subject if sent message is raw', function(done) {
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver('amq.topic/not-news'),
@@ -64,7 +64,7 @@ describe('SenderLink', function() {
   });
 
   it('should accept messages as the first parameter', function(done) {
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver('test.disposition.queue'),
@@ -93,7 +93,7 @@ describe('SenderLink', function() {
   }
 
   it('should send custom types', function(done) {
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver(config.defaultLink),
@@ -112,7 +112,7 @@ describe('SenderLink', function() {
 
   it('should send and receive multi-frame messages', function(done) {
     var messageData = new Array(2048).join('0');
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver(config.defaultLink),

test/integration/qpid/streams.test.js

@@ -27,7 +27,7 @@ describe('QPID', function() {
       var expected = Array.apply(null, new Array(100))
         .map(function(a) { return Math.floor(Math.random() * 100); });
 
-      return Promise.all([
+      Promise.all([
         test.client.createReceiverStream(config.defaultLink),
         test.client.createSender(config.defaultLink)
       ])
@@ -59,7 +59,7 @@ describe('QPID', function() {
       var expected = Array.apply(null, new Array(100))
         .map(function(a) { return Math.floor(Math.random() * 100); });
 
-      return Promise.all([
+      Promise.all([
         test.client.createReceiver(config.defaultLink),
         test.client.createSenderStream(config.defaultLink)
       ])
@@ -81,7 +81,7 @@ describe('QPID', function() {
       var expected = Array.apply(null, new Array(100))
         .map(function(a) { return Math.floor(Math.random() * 100); });
 
-      return Promise.all([
+      Promise.all([
         test.client.createReceiver(config.defaultLink),
         test.client.createSenderStream(config.defaultLink, { callback: 'sent' })
       ])
@@ -108,7 +108,7 @@ describe('QPID', function() {
       var expected = Array.apply(null, new Array(100))
         .map(function(a) { return Math.floor(Math.random() * 100); });
 
-      return Promise.all([
+      Promise.all([
         test.client.createReceiver(config.defaultLink),
         test.client.createReceiverStream('test.streams.queue'),
         test.client.createSenderStream(config.defaultLink),

test/integration/servicebus/eventhubs/client.test.js

@@ -31,7 +31,7 @@ describe('EventHubs', function () {
     expect(config.senderLink, 'Required env vars not found in ' + Object.keys(process.env)).to.exist;
 
     var msgVal = uuid.v4();
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return createPartitionReceivers(test.client, config.partitionCount, config.receiverLinkPrefix);
       })
@@ -62,7 +62,7 @@ describe('EventHubs', function () {
       } } }
     };
 
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return createPartitionReceivers(test.client, config.partitionCount, config.receiverLinkPrefix, filterOptions);
       })

test/integration/servicebus/eventhubs/streams.test.js

@@ -42,7 +42,7 @@ describe('ServiceBus', function() {
           expected = Array.apply(null, new Array(20))
             .map(function(a) { return Math.floor(Math.random() * 100); });
 
-      return Promise.all([
+      Promise.all([
         test.client.createReceiverStream(config.receiverLinkPrefix + test.partition),
         test.client.createSender(config.partitionSenderLinkPrefix + test.partition)
       ])
@@ -71,7 +71,7 @@ describe('ServiceBus', function() {
           expected = Array.apply(null, new Array(20))
             .map(function(a) { return Math.floor(Math.random() * 100); });
 
-      return Promise.all([
+      Promise.all([
         test.client.createReceiver(config.receiverLinkPrefix + test.partition),
         test.client.createSenderStream(config.partitionSenderLinkPrefix + test.partition)
       ])

test/integration/servicebus/queues/client.test.js

@@ -22,7 +22,7 @@ describe('Queues', function() {
   it('should connect, send, and receive a message', function(done) {
     var msgVal = uuid.v4();
     test.client = new AMQPClient(Policy.ServiceBusQueue);
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver(config.defaultLink),
@@ -48,7 +48,7 @@ describe('Queues', function() {
 
     var count = 0;
     var acked = false;
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver(config.defaultLink),
@@ -87,7 +87,7 @@ describe('Queues', function() {
       receiverLink: { attach: { receiverSettleMode: 1 } }
     });
 
-    return test.client.connect(config.address)
+    test.client.connect(config.address)
       .then(function() {
         return Promise.all([
           test.client.createReceiver(config.defaultLink),

test/unit/client.test.js

@@ -102,7 +102,7 @@ describe('Client', function() {
         })
       ]);
 
-      return test.client.connect(test.server.address())
+      test.client.connect(test.server.address())
         .tap(function() {
           test.client._connection.on('connection:errorReceived', function(err) {
             expect(err.condition).to.eql('amqp:connection:forced');
@@ -145,7 +145,7 @@ describe('Client', function() {
         })
       ]);
 
-      return test.client.connect(test.server.address())
+      test.client.connect(test.server.address())
         .then(function() { return test.client.createReceiver('testing'); })
         .then(function (rxLink) {
           rxLink.on('message', function (msg) {
@@ -211,7 +211,7 @@ describe('Client', function() {
         })
       ]);
 
-      return test.client.connect(test.server.address())
+      test.client.connect(test.server.address())
         .then(function() { return test.client.createReceiver('testing'); })
         .then(function (rxLink) {
           rxLink.on('message', function (msg) {