fix(recv-link): distinguish auto/manual settlement #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- default to rcv-settle-mode "first" everywhere, we don't currently handle "second" correctly anyway - add link policy attribute "settlement" to distinguish between auto, where the client will immediately accept messages on receipt, and manual where the user is expected to call accept when they have finished handling a delivery. Fixes noodlefrenzy#316
mmaestri
reviewed
Jun 15, 2017
lib/receiver_link.js
Outdated
| @@ -192,7 +192,7 @@ ReceiverLink.prototype._messageReceived = function(transferFrame) { | |||
| // @todo: Bump link credit based on strategy | |||
|
|
|||
| // respect settle mode in policy | |||
| if (this.policy.attach.rcvSettleMode === constants.receiverSettleMode.autoSettle) { | |||
| if (this.policy.settlement === constants.settlement.manual) { | |||
There was a problem hiding this comment.
actually this should be
if (this.policy.settlement === constants.settlement.auto) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should probably be a major version bump as the API is changed
"second" correctly anyway
where the client will immediately accept messages on receipt, and manual
where the user is expected to call accept when they have finished
handling a delivery.
Fixes #316
This change is